ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce zeroing through memset to ensure padding is zeroed with llvm api

Browse Source
This commit is contained in:
gingerBill
2020-11-25 19:50:48 +00:00
parent 1acd5acd70
commit 70f5d7a1c9
1 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend.cpp
+20 -2
View File
@@ -2961,11 +2961,29 @@ lbAddr lb_add_local(lbProcedure *p, Type *type, Entity *e, bool zero_init, i32 p
LLVMTypeRef llvm_type = lb_type(p->module, type); LLVMTypeRef llvm_type = lb_type(p->module, type);
LLVMValueRef ptr = LLVMBuildAlloca(p->builder, llvm_type, name); LLVMValueRef ptr = LLVMBuildAlloca(p->builder, llvm_type, name);
LLVMSetAlignment(ptr, 16); // TODO(bill): Make this configurable
// unsigned alignment = 16; // TODO(bill): Make this configurable
unsigned alignment = cast(unsigned)lb_alignof(llvm_type);
LLVMSetAlignment(ptr, alignment);
LLVMPositionBuilderAtEnd(p->builder, p->curr_block->block); LLVMPositionBuilderAtEnd(p->builder, p->curr_block->block);
if (zero_init) { if (zero_init) {
LLVMBuildStore(p->builder, LLVMConstNull(lb_type(p->module, type)), ptr); LLVMTypeKind kind = LLVMGetTypeKind(llvm_type);
switch (kind) {
case LLVMStructTypeKind:
case LLVMArrayTypeKind:
{
// NOTE(bill): Enforce zeroing through memset to make sure padding is zeroed too
LLVMTypeRef type_i8 = LLVMInt8TypeInContext(p->module->ctx);
LLVMTypeRef type_i32 = LLVMInt32TypeInContext(p->module->ctx);
i32 sz = cast(i32)type_size_of(type);
LLVMBuildMemSet(p->builder, ptr, LLVMConstNull(type_i8), LLVMConstInt(type_i32, sz, false), alignment);
}
break;
default:
LLVMBuildStore(p->builder, LLVMConstNull(lb_type(p->module, type)), ptr);
}
} }
lbValue val = {}; lbValue val = {};