ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-01 04:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add ~{memory} clobber to syscall intrinsics for platforms where it was not yet added.

Browse Source 
This fixes #4972 and #4588.

As laytan asserts, there is no guarantee that a syscall will not modify memory that it just obtained from the user, or held onto via a previous syscall. Therefore this constraint should be required for all syscalls.
This commit is contained in:
Harold Brenes
2025-03-26 19:25:06 -04:00
parent 94152ca701
commit 6fda041e17
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/llvm_backend_proc.cpp
+10
View File
@@ -2972,6 +2972,8 @@ gb_internal lbValue lb_build_builtin_proc(lbProcedure *p, Ast *expr, TypeAndValu
constraints = gb_string_appendc(constraints, "}"); constraints = gb_string_appendc(constraints, "}");
} }
constraints = gb_string_appendc(constraints, ",~{memory}");
inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints)); inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints));
} }
break; break;
@@ -3034,6 +3036,8 @@ gb_internal lbValue lb_build_builtin_proc(lbProcedure *p, Ast *expr, TypeAndValu
constraints = gb_string_appendc(constraints, "}"); constraints = gb_string_appendc(constraints, "}");
} }
constraints = gb_string_appendc(constraints, ",~{memory}");
inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints)); inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints));
} }
break; break;
@@ -3059,6 +3063,8 @@ gb_internal lbValue lb_build_builtin_proc(lbProcedure *p, Ast *expr, TypeAndValu
constraints = gb_string_appendc(constraints, "}"); constraints = gb_string_appendc(constraints, "}");
} }
constraints = gb_string_appendc(constraints, ",~{memory}");
inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints)); inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints));
} else { } else {
char asm_string[] = "svc #0"; char asm_string[] = "svc #0";
@@ -3078,6 +3084,8 @@ gb_internal lbValue lb_build_builtin_proc(lbProcedure *p, Ast *expr, TypeAndValu
constraints = gb_string_appendc(constraints, "}"); constraints = gb_string_appendc(constraints, "}");
} }
constraints = gb_string_appendc(constraints, ",~{memory}");
inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints)); inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints));
} }
} }
@@ -3104,6 +3112,8 @@ gb_internal lbValue lb_build_builtin_proc(lbProcedure *p, Ast *expr, TypeAndValu
constraints = gb_string_appendc(constraints, "}"); constraints = gb_string_appendc(constraints, "}");
} }
constraints = gb_string_appendc(constraints, ",~{memory}");
inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints)); inline_asm = llvm_get_inline_asm(func_type, make_string_c(asm_string), make_string_c(constraints));
} }
break; break;