ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-07 08:08:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3320

Browse Source
This commit is contained in:
gingerBill
2024-03-24 13:40:10 +00:00
parent 87688936c6
commit 6da6393735
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+10 -9
View File
@@ -1174,6 +1174,16 @@ gb_internal void check_assignment(CheckerContext *c, Operand *operand, Type *typ
type_str, type_extra, type_str, type_extra,
LIT(context_name)); LIT(context_name));
check_assignment_error_suggestion(c, operand, type); check_assignment_error_suggestion(c, operand, type);
if (context_name == "procedure argument") {
Type *src = base_type(operand->type);
Type *dst = base_type(type);
if (is_type_slice(src) && are_types_identical(src->Slice.elem, dst)) {
gbString a = expr_to_string(operand->expr);
error_line("\tSuggestion: Did you mean to pass the slice into the variadic parameter with ..%s?\n\n", a);
gb_string_free(a);
}
}
} }
break; break;
} }
@@ -5905,16 +5915,7 @@ gb_internal CallArgumentError check_call_arguments_internal(CheckerContext *c, A
s = assign_score_function(MAXIMUM_TYPE_DISTANCE); s = assign_score_function(MAXIMUM_TYPE_DISTANCE);
} else { } else {
if (show_error) { if (show_error) {
ERROR_BLOCK();
check_assignment(c, o, param_type, str_lit("procedure argument")); check_assignment(c, o, param_type, str_lit("procedure argument"));
Type *src = base_type(o->type);
Type *dst = base_type(param_type);
if (is_type_slice(src) && are_types_identical(src->Slice.elem, dst)) {
gbString a = expr_to_string(o->expr);
error_line("\tSuggestion: Did you mean to pass the slice into the variadic parameter with ..%s?\n\n", a);
gb_string_free(a);
}
} }
err = CallArgumentError_WrongTypes; err = CallArgumentError_WrongTypes;
} }