ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make the ABI changes only affect windows

Browse Source 
TODO: decide upon rules for *nix systems
This commit is contained in:
Ginger Bill
2017-04-17 12:01:04 +01:00
parent a213061f33
commit 6d9fadf351
1 changed files with 40 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.c
+40 -34
View File
@@ -1016,44 +1016,50 @@ Type *check_get_results(Checker *c, Scope *scope, AstNode *_results) {
Type *type_to_abi_compat_param_type(gbAllocator a, Type *original_type) { Type *type_to_abi_compat_param_type(gbAllocator a, Type *original_type) {
Type *new_type = original_type; Type *new_type = original_type;
// NOTE(bill): Changing the passing parameter value type is to match C's ABI
// IMPORTANT TODO(bill): This only matches the ABI on MSVC at the moment
// SEE: https://msdn.microsoft.com/en-us/library/zthk2dkh.aspx
Type *bt = core_type(original_type);
switch (bt->kind) {
// Okay to pass by value
// Especially the only Odin types
case Type_Basic: break;
case Type_Pointer: break;
case Type_Proc: break; // NOTE(bill): Just a pointer
// Odin only types if (str_eq(build_context.ODIN_OS, str_lit("windows"))) {
case Type_Slice: // NOTE(bill): Changing the passing parameter value type is to match C's ABI
case Type_DynamicArray: // IMPORTANT TODO(bill): This only matches the ABI on MSVC at the moment
case Type_Map: // SEE: https://msdn.microsoft.com/en-us/library/zthk2dkh.aspx
break; Type *bt = core_type(original_type);
switch (bt->kind) {
// Okay to pass by value
// Especially the only Odin types
case Type_Basic: break;
case Type_Pointer: break;
case Type_Proc: break; // NOTE(bill): Just a pointer
// Odin specific // Odin only types
case Type_Array: case Type_Slice:
case Type_Vector: case Type_DynamicArray:
// Could be in C too case Type_Map:
case Type_Record: {
i64 size = type_size_of(a, original_type);
switch (8*size) {
case 8: new_type = t_u8; break;
case 16: new_type = t_u16; break;
case 32: new_type = t_u32; break;
case 64: new_type = t_u64; break;
default:
// NOTE(bill): It could be an empty struct that is passed
// and if that is the case, no need to pass by pointer
// (I think..)
if (size > 0) {
new_type = make_type_pointer(a, original_type);
}
break; break;
// Odin specific
case Type_Array:
case Type_Vector:
// Could be in C too
case Type_Record: {
i64 size = type_size_of(a, original_type);
switch (8*size) {
case 8: new_type = t_u8; break;
case 16: new_type = t_u16; break;
case 32: new_type = t_u32; break;
case 64: new_type = t_u64; break;
default:
// NOTE(bill): It could be an empty struct that is passed
// and if that is the case, no need to pass by pointer
// (I think..)
if (size > 0) {
new_type = make_type_pointer(a, original_type);
}
break;
}
} break;
} }
} break; } else {
// IMPORTANT TODO(bill): figure out the ABI settings for Linux, OSX etc. for
// their architectures
} }
return new_type; return new_type;