From 6c0e2e2a53412b4d7ba8b2b3b9bd485af240589b Mon Sep 17 00:00:00 2001 From: Jeroen van Rijn Date: Sat, 14 May 2022 13:18:38 +0200 Subject: [PATCH] pool_join should look at .Done. --- core/thread/thread_pool.odin | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/core/thread/thread_pool.odin b/core/thread/thread_pool.odin index 4fd5c90d1..d27ae4255 100644 --- a/core/thread/thread_pool.odin +++ b/core/thread/thread_pool.odin @@ -101,16 +101,13 @@ pool_join :: proc(pool: ^Pool) { intrinsics.atomic_store(&pool.is_running, false) sync.post(&pool.sem_available, len(pool.threads)) - yield() - // Because we already stopped the pool, there's no need to take a lock here. - - started_count: int - for started_count < len(pool.threads) { - started_count = 0 + done_count: int + for done_count < len(pool.threads) { + done_count = 0 for t in pool.threads { - if .Started in t.flags { - started_count += 1 + if .Done in t.flags { + done_count += 1 if .Joined not_in t.flags { join(t) }