ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-05 15:18:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

test/core/sync/chan: serialize try_select tests

Browse Source 
These tests will race access to __global_context_for_test, which can
cause the test suite to flake. Even though only a single test actually
references the variable, the logic in try_select consumes it.
This commit is contained in:
Jack Mordaunt
2025-06-12 17:15:37 -03:00
parent fc7fc4d5cd
commit 52d38f1788
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/core/sync/chan/test_core_sync_chan.odin
+7 -3
View File
@@ -35,6 +35,10 @@ MAX_RAND :: 32
FAIL_TIME :: 1 * time.Second FAIL_TIME :: 1 * time.Second
SLEEP_TIME :: 1 * time.Millisecond SLEEP_TIME :: 1 * time.Millisecond
// Synchronizes try_select tests that require access to global state.
test_lock: sync.Mutex
__global_context_for_test: rawptr
comm_client :: proc(th: ^thread.Thread) { comm_client :: proc(th: ^thread.Thread) {
data := cast(^Comm)th.data data := cast(^Comm)th.data
manual_buffering := data.manual_buffering manual_buffering := data.manual_buffering
@@ -277,6 +281,7 @@ test_accept_message_from_closed_buffered_chan :: proc(t: ^testing.T) {
// operation will process it. // operation will process it.
@test @test
test_try_select_raw_happy :: proc(t: ^testing.T) { test_try_select_raw_happy :: proc(t: ^testing.T) {
sync.guard(&test_lock)
testing.set_fail_timeout(t, FAIL_TIME) testing.set_fail_timeout(t, FAIL_TIME)
recv1, recv1_err := chan.create(chan.Chan(int), context.allocator) recv1, recv1_err := chan.create(chan.Chan(int), context.allocator)
@@ -348,6 +353,7 @@ test_try_select_raw_happy :: proc(t: ^testing.T) {
// try_select_raw operation does not block. // try_select_raw operation does not block.
@test @test
test_try_select_raw_default_state :: proc(t: ^testing.T) { test_try_select_raw_default_state :: proc(t: ^testing.T) {
sync.guard(&test_lock)
testing.set_fail_timeout(t, FAIL_TIME) testing.set_fail_timeout(t, FAIL_TIME)
recv1, recv1_err := chan.create(chan.Chan(int), context.allocator) recv1, recv1_err := chan.create(chan.Chan(int), context.allocator)
@@ -374,6 +380,7 @@ test_try_select_raw_default_state :: proc(t: ^testing.T) {
// thread between calls to can_{send,recv} and try_{send,recv}_raw. // thread between calls to can_{send,recv} and try_{send,recv}_raw.
@test @test
test_try_select_raw_no_toctou :: proc(t: ^testing.T) { test_try_select_raw_no_toctou :: proc(t: ^testing.T) {
sync.guard(&test_lock)
testing.set_fail_timeout(t, FAIL_TIME) testing.set_fail_timeout(t, FAIL_TIME)
// Trigger will be used to coordinate between the thief and the try_select. // Trigger will be used to coordinate between the thief and the try_select.
@@ -382,9 +389,6 @@ test_try_select_raw_no_toctou :: proc(t: ^testing.T) {
assert(trigger_err == nil, "allocation failed") assert(trigger_err == nil, "allocation failed")
defer chan.destroy(trigger) defer chan.destroy(trigger)
@(static)
__global_context_for_test: rawptr
__global_context_for_test = &trigger __global_context_for_test = &trigger
defer __global_context_for_test = nil defer __global_context_for_test = nil