ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix constant representability rules

Browse Source
This commit is contained in:
gingerBill
2019-05-09 22:46:50 +01:00
parent 665734f04f
commit 3fc60930e6
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+3 -6
View File
@@ -526,12 +526,6 @@ i64 check_distance_between_types(CheckerContext *c, Operand *operand, Type *type
} }
if (is_type_bit_field_value(operand->type) && is_type_integer(type)) { if (is_type_bit_field_value(operand->type) && is_type_integer(type)) {
Type *bfv = base_type(operand->type);
i32 bits = bfv->BitFieldValue.bits;
i32 size = next_pow2((bits+7)/8);
i32 dst_size = cast(i32)type_size_of(type);
i32 diff = gb_abs(dst_size - size);
// TODO(bill): figure out a decent rule here
return 1; return 1;
} }
@@ -1306,6 +1300,9 @@ bool check_representable_as_constant(CheckerContext *c, ExactValue in_value, Typ
} else if (is_type_string(type)) { } else if (is_type_string(type)) {
return in_value.kind == ExactValue_String; return in_value.kind == ExactValue_String;
} else if (is_type_integer(type) || is_type_rune(type)) { } else if (is_type_integer(type) || is_type_rune(type)) {
if (in_value.kind == ExactValue_Bool) {
return false;
}
ExactValue v = exact_value_to_integer(in_value); ExactValue v = exact_value_to_integer(in_value);
if (v.kind != ExactValue_Integer) { if (v.kind != ExactValue_Integer) {
return false; return false;