ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-07 16:18:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add improved error message when doing ^x instead of &x for addressable variables

Browse Source
This commit is contained in:
gingerBill
2022-07-11 12:31:01 +01:00
parent 9e376fbda7
commit 37d04198ab
1 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_type.cpp
+22 -1
View File
@@ -2685,7 +2685,28 @@ bool check_type_internal(CheckerContext *ctx, Ast *e, Type **type, Type *named_t
case_end; case_end;
case_ast_node(pt, PointerType, e); case_ast_node(pt, PointerType, e);
*type = alloc_type_pointer(check_type(ctx, pt->type)); CheckerContext c = *ctx;
c.type_path = new_checker_type_path();
defer (destroy_checker_type_path(c.type_path));
Type *elem = t_invalid;
Operand o = {};
check_expr_or_type(&c, &o, pt->type);
if (o.mode != Addressing_Invalid && o.mode != Addressing_Type) {
// NOTE(bill): call check_type_expr again to get a consistent error message
begin_error_block();
elem = check_type_expr(&c, pt->type, nullptr);
if (o.mode == Addressing_Variable) {
gbString s = expr_to_string(pt->type);
error_line("\tSuggestion: ^ is used for pointer types, did you mean '&%s'?\n", s);
gb_string_free(s);
}
end_error_block();
} else {
elem = o.type;
}
*type = alloc_type_pointer(elem);
set_base_type(named_type, *type); set_base_type(named_type, *type);
return true; return true;
case_end; case_end;