Make core and vendor adhere to -vet, -strict-style, and -disallow-do

core/odin/ast/clone.odin

@@ -29,7 +29,7 @@ clone_array :: proc(array: $A/[]^$T) -> A {
 	}
 	res := make(A, len(array))
 	for elem, i in array {
-		res[i] = auto_cast clone(elem)
+		res[i] = (^T)(clone(elem))
 	}
 	return res
 }
@@ -40,7 +40,7 @@ clone_dynamic_array :: proc(array: $A/[dynamic]^$T) -> A {
 	}
 	res := make(A, len(array))
 	for elem, i in array {
-		res[i] = auto_cast clone(elem)
+		res[i] = (^T)(clone(elem))
 	}
 	return res
 }
@@ -169,10 +169,10 @@ clone_node :: proc(node: ^Node) -> ^Node {
 		r.lhs = clone(r.lhs)
 		r.rhs = clone(r.rhs)
 	case Block_Stmt:
-		r.label = auto_cast clone(r.label)
+		r.label = clone(r.label)
 		r.stmts = clone(r.stmts)
 	case If_Stmt:
-		r.label     = auto_cast clone(r.label)
+		r.label     = clone(r.label)
 		r.init      = clone(r.init)
 		r.cond      = clone(r.cond)
 		r.body      = clone(r.body)
@@ -186,13 +186,13 @@ clone_node :: proc(node: ^Node) -> ^Node {
 	case Defer_Stmt:
 		r.stmt = clone(r.stmt)
 	case For_Stmt:
-		r.label = auto_cast clone(r.label)
+		r.label = clone(r.label)
 		r.init = clone(r.init)
 		r.cond = clone(r.cond)
 		r.post = clone(r.post)
 		r.body = clone(r.body)
 	case Range_Stmt:
-		r.label = auto_cast clone(r.label)
+		r.label = clone(r.label)
 		r.vals = clone(r.vals)
 		r.expr = clone(r.expr)
 		r.body = clone(r.body)
@@ -200,12 +200,12 @@ clone_node :: proc(node: ^Node) -> ^Node {
 		r.list = clone(r.list)
 		r.body = clone(r.body)
 	case Switch_Stmt:
-		r.label = auto_cast clone(r.label)
+		r.label = clone(r.label)
 		r.init = clone(r.init)
 		r.cond = clone(r.cond)
 		r.body = clone(r.body)
 	case Type_Switch_Stmt:
-		r.label = auto_cast clone(r.label)
+		r.label = clone(r.label)
 		r.tag  = clone(r.tag)
 		r.expr = clone(r.expr)
 		r.body = clone(r.body)

core/odin/parser/parser.odin

@@ -414,7 +414,7 @@ expect_closing_brace_of_field_list :: proc(p: ^Parser) -> tokenizer.Token {
 	}
 	if allow_token(p, .Semicolon) {
 		str := tokenizer.token_to_string(token)
-		error(p, end_of_line_pos(p, p.prev_tok), "expected a comma, got %s", p)
+		error(p, end_of_line_pos(p, p.prev_tok), "expected a comma, got %s", str)
 	}
 	return expect_token(p, .Close_Brace)
 }

core/odin/printer/printer.odin

@@ -237,7 +237,7 @@ format_value_decl :: proc(p: ^Printer, index: int) {
 	align_next := false
 
 	//check to see if there is a binary operator in the last token(this is guaranteed by the ast visit), otherwise it's not multilined
-	for line, line_index in p.lines[eq_line:] {
+	for line in p.lines[eq_line:] {
 
 		if len(line.format_tokens) == 0 {
 			break
@@ -309,7 +309,7 @@ format_call :: proc(p: ^Printer, line_index: int, format_index: int) {
 	paren_count := 1
 	done        := false
 
-	for line, line_index in p.lines[paren_line:] {
+	for line in p.lines[paren_line:] {
 
 		if len(line.format_tokens) == 0 {
 			continue
@@ -374,7 +374,7 @@ format_keyword_to_brace :: proc(p: ^Printer, line_index: int, format_index: int,
 		panic("Should not be possible")
 	}
 
-	for line, line_index in p.lines[keyword_line:] {
+	for line, line_idx in p.lines[keyword_line:] {
 
 		if len(line.format_tokens) == 0 {
 			continue
@@ -388,7 +388,7 @@ format_keyword_to_brace :: proc(p: ^Printer, line_index: int, format_index: int,
 				return
 			}
 
-			if line_index == 0 && i <= format_index {
+			if line_idx == 0 && i <= format_index {
 				continue
 			}
 
@@ -403,7 +403,7 @@ format_keyword_to_brace :: proc(p: ^Printer, line_index: int, format_index: int,
 			}
 		}
 
-		if line_index != 0 {
+		if line_idx != 0 {
 			line.format_tokens[0].spaces_before = largest + 1
 		}
 
@@ -908,7 +908,7 @@ align_comments :: proc(p: ^Printer) {
 
 			length := 0
 
-			for format_token, i in l.format_tokens {
+			for format_token in l.format_tokens {
 				if format_token.kind == .Comment {
 					if len(l.format_tokens) == 1 {
 						l.format_tokens[i].spaces_before = info.length + 1

core/odin/printer/visit.odin

@@ -499,7 +499,7 @@ visit_attributes :: proc(p: ^Printer, attributes: [dynamic]^ast.Attribute) {
 		return
 	}
 
-	for attribute, i in attributes {
+	for attribute in attributes {
 		move_line_limit(p, attribute.pos, 1)
 
 		push_generic_token(p, .At, 0)
@@ -1389,7 +1389,6 @@ visit_proc_type :: proc(p: ^Printer, proc_type: ast.Proc_Type, is_proc_lit := fa
 		push_generic_token(p, .Gt, 0)
 
 		use_parens := false
-		use_named  := false
 
 		if len(proc_type.results.list) > 1 {
 			use_parens = true