ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 23:58:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Inline some ptr set iterators

Browse Source
This commit is contained in:
gingerBill
2025-09-10 20:02:39 +01:00
parent 1c648126c7
commit 228ddd6903
2 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/checker.cpp
+13 -4
View File
@@ -2996,7 +2996,7 @@ gb_internal void generate_minimum_dependency_set(Checker *c, Entity *start) {
#undef FORCE_ADD_RUNTIME_ENTITIES #undef FORCE_ADD_RUNTIME_ENTITIES
} }
gb_internal bool is_entity_a_dependency(Entity *e) { gb_internal gb_inline bool is_entity_a_dependency(Entity *e) {
if (e == nullptr) return false; if (e == nullptr) return false;
switch (e->kind) { switch (e->kind) {
case Entity_Procedure: case Entity_Procedure:
@@ -3047,7 +3047,9 @@ gb_internal Array<EntityGraphNode *> generate_entity_dependency_graph(CheckerInf
DeclInfo *decl = decl_info_of_entity(e); DeclInfo *decl = decl_info_of_entity(e);
GB_ASSERT(decl != nullptr); GB_ASSERT(decl != nullptr);
for (Entity *dep : decl->deps) { FOR_PTR_SET(i_dep, decl->deps) {
Entity *dep = decl->deps.keys[i_dep];
if (dep->flags & EntityFlag_Field) { if (dep->flags & EntityFlag_Field) {
continue; continue;
} }
@@ -3078,14 +3080,21 @@ gb_internal Array<EntityGraphNode *> generate_entity_dependency_graph(CheckerInf
// Connect each pred 'p' of 'n' with each succ 's' and from // Connect each pred 'p' of 'n' with each succ 's' and from
// the procedure node // the procedure node
for (EntityGraphNode *p : n->pred) { FOR_PTR_SET(i_p, n->pred) {
EntityGraphNode *p = n->pred.keys[i_p];
// Ignore self-cycles // Ignore self-cycles
if (p == n) { if (p == n) {
continue; continue;
} }
// Each succ 's' of 'n' becomes a succ of 'p', and // Each succ 's' of 'n' becomes a succ of 'p', and
// each pred 'p' of 'n' becomes a pred of 's' // each pred 'p' of 'n' becomes a pred of 's'
for (EntityGraphNode *s : n->succ) { FOR_PTR_SET(i_s, n->succ) {
EntityGraphNode *s = n->succ.keys[i_s];
if (s == nullptr || s == cast(EntityGraphNode *)PtrSet<EntityGraphNode *>::TOMBSTONE) {
// NOTE(bill): This is inlined to improve development build performance
continue;
}
// Ignore self-cycles // Ignore self-cycles
if (s == n) { if (s == n) {
continue; continue;
src/ptr_set.cpp
+4 -1
View File
@@ -239,4 +239,7 @@ gb_internal PtrSetIterator<T> begin(PtrSet<T> &set) noexcept {
template <typename T> template <typename T>
gb_internal PtrSetIterator<T> end(PtrSet<T> &set) noexcept { gb_internal PtrSetIterator<T> end(PtrSet<T> &set) noexcept {
return PtrSetIterator<T>{&set, set.capacity}; return PtrSetIterator<T>{&set, set.capacity};
} }
#define FOR_PTR_SET(index_, set_) for (usize index_ = 0; index_ < (set_).capacity; index_++) if ((set_).keys[index_] != nullptr && (set_).keys[index_] != cast(void *)~(uintptr)(0ull))