ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-08 00:28:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disallow unnamed polymorphic records

Browse Source
This commit is contained in:
gingerBill
2021-04-29 11:00:14 +01:00
parent bee637aef1
commit 222bab501c
1 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+31
View File
@@ -5476,6 +5476,15 @@ ExprKind check_call_expr(CheckerContext *c, Operand *operand, Ast *call, Ast *pr
if (operand->mode == Addressing_Type) { if (operand->mode == Addressing_Type) {
Type *t = operand->type; Type *t = operand->type;
if (is_type_polymorphic_record(t)) { if (is_type_polymorphic_record(t)) {
if (!is_type_named(t)) {
gbString s = expr_to_string(operand->expr);
error(call, "Illegal use of an unnamed polymorphic record, %s", s);
gb_string_free(s);
operand->mode = Addressing_Invalid;
operand->type = t_invalid;;
return Expr_Expr;
}
auto err = check_polymorphic_record_type(c, operand, call); auto err = check_polymorphic_record_type(c, operand, call);
if (err == 0) { if (err == 0) {
Ast *ident = operand->expr; Ast *ident = operand->expr;
@@ -8526,8 +8535,18 @@ gbString write_expr_to_string(gbString str, Ast *node, bool shorthand) {
case_ast_node(st, StructType, node); case_ast_node(st, StructType, node);
str = gb_string_appendc(str, "struct "); str = gb_string_appendc(str, "struct ");
if (st->polymorphic_params) {
str = gb_string_append_rune(str, '(');
str = write_expr_to_string(str, st->polymorphic_params, shorthand);
str = gb_string_appendc(str, ") ");
}
if (st->is_packed) str = gb_string_appendc(str, "#packed "); if (st->is_packed) str = gb_string_appendc(str, "#packed ");
if (st->is_raw_union) str = gb_string_appendc(str, "#raw_union "); if (st->is_raw_union) str = gb_string_appendc(str, "#raw_union ");
if (st->align) {
str = gb_string_appendc(str, "#align ");
str = write_expr_to_string(str, st->align, shorthand);
str = gb_string_append_rune(str, ' ');
}
str = gb_string_append_rune(str, '{'); str = gb_string_append_rune(str, '{');
if (shorthand) { if (shorthand) {
str = gb_string_appendc(str, "..."); str = gb_string_appendc(str, "...");
@@ -8540,6 +8559,18 @@ gbString write_expr_to_string(gbString str, Ast *node, bool shorthand) {
case_ast_node(st, UnionType, node); case_ast_node(st, UnionType, node);
str = gb_string_appendc(str, "union "); str = gb_string_appendc(str, "union ");
if (st->polymorphic_params) {
str = gb_string_append_rune(str, '(');
str = write_expr_to_string(str, st->polymorphic_params, shorthand);
str = gb_string_appendc(str, ") ");
}
if (st->no_nil) str = gb_string_appendc(str, "#no_nil ");
if (st->maybe) str = gb_string_appendc(str, "#maybe ");
if (st->align) {
str = gb_string_appendc(str, "#align ");
str = write_expr_to_string(str, st->align, shorthand);
str = gb_string_append_rune(str, ' ');
}
str = gb_string_append_rune(str, '{'); str = gb_string_append_rune(str, '{');
if (shorthand) { if (shorthand) {
str = gb_string_appendc(str, "..."); str = gb_string_appendc(str, "...");