Correct alloc_from_memory_block

This commit is contained in:
gingerBill
2022-03-01 15:38:04 +00:00
parent ed933b3f21
commit 18607e53cb
2 changed files with 47 additions and 15 deletions
+28 -12
View File
@@ -82,11 +82,13 @@ memory_block_alloc :: proc(committed, reserved: uint, flags: Memory_Block_Flags)
pmblock := platform_memory_alloc(0, total_size) or_return pmblock := platform_memory_alloc(0, total_size) or_return
pmblock.block.base = ([^]byte)(uintptr(pmblock) + base_offset) pmblock.block.base = ([^]byte)(uintptr(pmblock) + base_offset)
commit(pmblock.block.base, committed) or_return commit_err := platform_memory_commit(pmblock, uint(base_offset) + committed)
assert(commit_err == nil)
// Should be zeroed // Should be zeroed
assert(pmblock.block.used == 0) assert(pmblock.block.used == 0)
assert(pmblock.block.prev == nil) assert(pmblock.block.prev == nil)
if (do_protection) { if do_protection {
protect(rawptr(uintptr(pmblock) + protect_offset), page_size, Protect_No_Access) protect(rawptr(uintptr(pmblock) + protect_offset), page_size, Protect_No_Access)
} }
@@ -115,23 +117,37 @@ alloc_from_memory_block :: proc(block: ^Memory_Block, min_size, alignment: int)
return alignment_offset return alignment_offset
} }
do_commit_if_necessary :: proc(block: ^Memory_Block, size: uint) -> (err: Allocator_Error) {
if block.committed - block.used < size {
pmblock := (^Platform_Memory_Block)(block)
base_offset := uint(uintptr(block) - uintptr(pmblock))
platform_total_commit := base_offset + block.used + size
assert(pmblock.committed <= pmblock.reserved)
assert(pmblock.committed < platform_total_commit)
platform_memory_commit(pmblock, platform_total_commit) or_return
pmblock.committed = platform_total_commit
block.committed = pmblock.committed - base_offset
}
return nil
}
alignment_offset := calc_alignment_offset(block, uintptr(alignment)) alignment_offset := calc_alignment_offset(block, uintptr(alignment))
size := uint(min_size) + alignment_offset size := uint(min_size) + alignment_offset
if block.used + size > block.reserved { if block.used + size > block.reserved {
err = .Out_Of_Memory err = .Out_Of_Memory
return return
} }
assert(block.committed <= block.reserved)
ptr := block.base[block.used:] do_commit_if_necessary(block, size) or_return
ptr = ptr[alignment_offset:]
data = block.base[block.used+alignment_offset:][:min_size]
block.used += size block.used += size
assert(block.used <= block.reserved) return
return ptr[:min_size], nil
} }
+19 -3
View File
@@ -4,8 +4,9 @@ package mem_virtual
import sync "core:sync/sync2" import sync "core:sync/sync2"
Platform_Memory_Block :: struct { Platform_Memory_Block :: struct {
block: Memory_Block, block: Memory_Block,
reserved: uint, committed: uint,
reserved: uint,
prev, next: ^Platform_Memory_Block, prev, next: ^Platform_Memory_Block,
} }
@@ -20,7 +21,8 @@ platform_memory_alloc :: proc(to_commit, to_reserve: uint) -> (block: ^Platform_
commit(raw_data(data), to_commit) commit(raw_data(data), to_commit)
block = (^Platform_Memory_Block)(raw_data(data)) block = (^Platform_Memory_Block)(raw_data(data))
block.reserved = to_reserve block.committed = to_commit
block.reserved = to_reserve
return return
} }
@@ -52,3 +54,17 @@ platform_memory_init :: proc() {
global_platform_memory_block_sentinel_set = true global_platform_memory_block_sentinel_set = true
} }
} }
platform_memory_commit :: proc(block: ^Platform_Memory_Block, to_commit: uint) -> (err: Allocator_Error) {
if to_commit < block.committed {
return nil
}
if to_commit > block.reserved {
return .Out_Of_Memory
}
commit(block, to_commit) or_return
block.committed = to_commit
return nil
}