ed/Odin
1
0
Fork 0
mirror of https://github.com/Ed94/Odin.git synced 2026-08-06 15:48:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve type inference for procedure group stuff

Browse Source
This commit is contained in:
gingerBill
2023-07-17 13:03:58 +01:00
parent 88485d5467
commit 0f28857c59
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/check_expr.cpp
+2 -6
View File
@@ -6136,7 +6136,6 @@ gb_internal CallArgumentData check_call_arguments_proc_group(CheckerContext *c,
{ {
// NOTE(bill, 2019-07-13): This code is used to improve the type inference for procedure groups // NOTE(bill, 2019-07-13): This code is used to improve the type inference for procedure groups
// where the same positional parameter has the same type value (and ellipsis) // where the same positional parameter has the same type value (and ellipsis)
bool proc_arg_count_all_equal = true;
isize proc_arg_count = -1; isize proc_arg_count = -1;
for (Entity *p : procs) { for (Entity *p : procs) {
Type *pt = base_type(p->type); Type *pt = base_type(p->type);
@@ -6144,15 +6143,12 @@ gb_internal CallArgumentData check_call_arguments_proc_group(CheckerContext *c,
if (proc_arg_count < 0) { if (proc_arg_count < 0) {
proc_arg_count = pt->Proc.param_count; proc_arg_count = pt->Proc.param_count;
} else { } else {
if (proc_arg_count != pt->Proc.param_count) { proc_arg_count = gb_min(proc_arg_count, pt->Proc.param_count);
proc_arg_count_all_equal = false;
break;
}
} }
} }
} }
if (proc_arg_count >= 0 && proc_arg_count_all_equal) { if (proc_arg_count >= 0) {
lhs_count = proc_arg_count; lhs_count = proc_arg_count;
if (lhs_count > 0) { if (lhs_count > 0) {
lhs = gb_alloc_array(heap_allocator(), Entity *, lhs_count); lhs = gb_alloc_array(heap_allocator(), Entity *, lhs_count);